Skip to content

Commit

Permalink
refactor: provide description to default publisher (#4564)
Browse files Browse the repository at this point in the history
- closes #4554
```
bacalhau config list | grep publisher
16:20:07.717 | INF cmd/cli/config/list.go:44 > Config loaded from: [], and with data-dir /home/frrist/.bacalhau
 jobdefaults.batch.task.publisher.params           map[]                        Params specifies the publisher configuration data.                               
 jobdefaults.batch.task.publisher.type                                          Type specifies the publisher type. e.g. "s3", "local", "ipfs", etc.              
 jobdefaults.ops.task.publisher.params             map[]                        Params specifies the publisher configuration data.                               
 jobdefaults.ops.task.publisher.type                                            Type specifies the publisher type. e.g. "s3", "local", "ipfs", etc.        
 ```
- closes #4534 
```
bacalhau config list  | grep port
16:20:44.084 | INF cmd/cli/config/list.go:44 > Config loaded from: [],
and with data-dir /home/frrist/.bacalhau
api.port 1234 Port specifies the port number on which the API server
listens or the client
orchestrator.cluster.port 0 Port specifies the port number for cluster
communication.
orchestrator.port 4222 Host specifies the port number on which the
Orchestrator server listens for
publishers.types.local.port 0 Port specifies the port the publisher
serves on.
webui.listen 0.0.0.0:8438 Listen specifies the address and port on which
the Web UI listens.
 ```

---------

Co-authored-by: frrist <[email protected]>
  • Loading branch information
frrist and frrist authored Oct 3, 2024
1 parent f94ea7b commit ad2a45c
Show file tree
Hide file tree
Showing 9 changed files with 469 additions and 292 deletions.
2 changes: 1 addition & 1 deletion cmd/util/flags/configflags/publishing.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var PublishingFlags = []Definition{
Deprecated: true,
DeprecatedMessage: fmt.Sprintf("Use one or more of the following options, all are accepted %s, %s",
makeConfigFlagDeprecationCommand(types.JobDefaultsBatchTaskPublisherTypeKey),
makeConfigFlagDeprecationCommand(types.JobDefaultsOpsTaskPublisherParamsKey),
makeConfigFlagDeprecationCommand(types.JobDefaultsOpsTaskPublisherTypeKey),
),
},
}
1 change: 1 addition & 0 deletions pkg/config/types/bacalhau.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
// NB: Developers, after making changes (comments included) to this struct or any of its children, run go generate.

//go:generate go run gen/generate.go ./
//go:generate go fmt ./generated_constants.go ./generated_descriptions.go
type Bacalhau struct {
API API `yaml:"API,omitempty" json:"API,omitempty"`
// NameProvider specifies the method used to generate names for the node. One of: hostname, aws, gcp, uuid, puuid.
Expand Down
Loading

0 comments on commit ad2a45c

Please sign in to comment.