Skip to content

Commit

Permalink
Fix printing deprecated logs command (#4253)
Browse files Browse the repository at this point in the history
Fixes #4235
  • Loading branch information
wdbaruni authored Jul 29, 2024
1 parent e71b30b commit 50628bd
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions clients/python/bacalhau_apiclient/models/execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ def revision(self, revision):
def run_output(self):
"""Gets the run_output of this Execution. # noqa: E501
RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau logs` # noqa: E501
RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs` # noqa: E501
:return: The run_output of this Execution. # noqa: E501
:rtype: AllOfExecutionRunOutput
Expand All @@ -533,7 +533,7 @@ def run_output(self):
def run_output(self, run_output):
"""Sets the run_output of this Execution.
RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau logs` # noqa: E501
RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs` # noqa: E501
:param run_output: The run_output of this Execution. # noqa: E501
:type: AllOfExecutionRunOutput
Expand Down
2 changes: 1 addition & 1 deletion clients/python/docs/Execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Name | Type | Description | Notes
**previous_execution** | **str** | PreviousExecution is the execution that this execution is replacing | [optional]
**published_result** | **AllOfExecutionPublishedResult** | the published results for this execution | [optional]
**revision** | **int** | Revision is increment each time the execution is updated. | [optional]
**run_output** | **AllOfExecutionRunOutput** | RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau logs` | [optional]
**run_output** | **AllOfExecutionRunOutput** | RunOutput is the output of the run command TODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs` | [optional]

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

2 changes: 1 addition & 1 deletion cmd/util/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func DownloadResultsHandler(
// No results doesn't mean error, so we should print out a message and return nil
cmd.Println("No results found")
cmd.Println("You can check the logged output of the job using the logs command.")
cmd.Printf("\n bacalhau logs %s\n", jobID)
cmd.Printf("\n bacalhau job logs %s\n", jobID)
return nil
}

Expand Down
2 changes: 1 addition & 1 deletion docs/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@
"type": "integer"
},
"RunOutput": {
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau logs`",
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs`",
"allOf": [
{
"$ref": "#/definitions/models.RunCommandResult"
Expand Down
2 changes: 1 addition & 1 deletion pkg/models/execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ type Execution struct {
PublishedResult *SpecConfig `json:"PublishedResult"`

// RunOutput is the output of the run command
// TODO: evaluate removing this from execution spec in favour of calling `bacalhau logs`
// TODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs`
RunOutput *RunCommandResult `json:"RunOutput"`

// PreviousExecution is the execution that this execution is replacing
Expand Down
2 changes: 1 addition & 1 deletion pkg/swagger/docs.go
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ const docTemplate = `{
"type": "integer"
},
"RunOutput": {
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling ` + "`" + `bacalhau logs` + "`" + `",
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling ` + "`" + `bacalhau job logs` + "`" + `",
"allOf": [
{
"$ref": "#/definitions/models.RunCommandResult"
Expand Down
2 changes: 1 addition & 1 deletion pkg/swagger/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@
"type": "integer"
},
"RunOutput": {
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau logs`",
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs`",
"allOf": [
{
"$ref": "#/definitions/models.RunCommandResult"
Expand Down
2 changes: 1 addition & 1 deletion webui/public/swagger/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@
"type": "integer"
},
"RunOutput": {
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau logs`",
"description": "RunOutput is the output of the run command\nTODO: evaluate removing this from execution spec in favour of calling `bacalhau job logs`",
"allOf": [
{
"$ref": "#/definitions/models.RunCommandResult"
Expand Down

0 comments on commit 50628bd

Please sign in to comment.