Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Provisioning Now Working, Has Bugs #41

Merged
merged 34 commits into from
Dec 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
676ffd8
refactor: Update SOP to reflect current project implementation status
aronchick Dec 10, 2024
61fcd55
refactor: Rename createRegionalInfrastructure method to CreateRegiona…
aronchick Dec 10, 2024
29a3477
refactor: Update getRegionAvailabilityZones to use regional EC2 client
aronchick Dec 10, 2024
af3e244
refactor: Prevent automatic stdout logging in logger initialization
aronchick Dec 11, 2024
9179654
refactor: Disable console logging by always returning nil in createCo…
aronchick Dec 11, 2024
0797bfc
refactor: Prevent console logging by disabling console core and calle…
aronchick Dec 11, 2024
7a4b17e
fix: Remove invalid zap.WithOptions() call in logger initialization
aronchick Dec 11, 2024
9df7dfb
refactor: Remove unused code and update regional resource handling
aronchick Dec 11, 2024
5c640d7
refactor: Modify setupNetworking to create Internet Gateway for all V…
aronchick Dec 11, 2024
e946bdf
refactor: Modify setupNetworking to create Internet Gateways for all …
aronchick Dec 11, 2024
11a3959
fix: Define regionalClient in AWS provider's setupNetworking method
aronchick Dec 11, 2024
b102f50
refactor: Update VPC cleanup to use regional clients and modify funct…
aronchick Dec 11, 2024
e7a4c62
test: Fix AWS networking setup timeout and improve error handling
aronchick Dec 11, 2024
7ed638d
style: Apply linter formatting to AWS provider code
aronchick Dec 11, 2024
2c5c1a8
feat: Enhance VPC creation with logging, tagging, and resource manage…
aronchick Dec 11, 2024
21c8089
feat: Enhance VPC infrastructure creation with improved logging and t…
aronchick Dec 11, 2024
d823c5c
refactor: Improve error handling and logging for multi-region AWS inf…
aronchick Dec 11, 2024
5a0e1ac
refactor: Improve VPC creation error handling and logging in AWS prov…
aronchick Dec 11, 2024
8f3af6d
fixing locations
aronchick Dec 12, 2024
5b81ffb
refactor: Improve AWS provider infrastructure setup and region handling
aronchick Dec 12, 2024
5ae3c13
refactor: Enhance network connectivity logging with route table and i…
aronchick Dec 12, 2024
3625a2a
feat: Add comprehensive VPC infrastructure creation method with detai…
aronchick Dec 12, 2024
30b802c
feat: Ensure unique internet gateway creation for each VPC
aronchick Dec 12, 2024
2acd6cb
refactor: Enhance VPC networking setup with detailed logging and veri…
aronchick Dec 12, 2024
9736d9f
test: Add network diagnostics to AWS provider
aronchick Dec 12, 2024
2e306d4
basic amazon now working
aronchick Dec 14, 2024
975d05e
Update internal/clouds/general/location.go
aronchick Dec 14, 2024
b37ef74
Update internal/clouds/general/location.go
aronchick Dec 14, 2024
e3a39ea
Update cmd/beta/aws/create_deployment.go
aronchick Dec 14, 2024
bfa4b27
merge from main
aronchick Dec 14, 2024
d5803f6
spelling fix
aronchick Dec 14, 2024
d7a529d
removing duplicate mocks
aronchick Dec 14, 2024
27383d3
tests passing
aronchick Dec 24, 2024
4358b1d
Merge branch 'main' into aronchick/aws-spot-part-3-remaining-resources
aronchick Dec 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update internal/clouds/general/location.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
  • Loading branch information
aronchick and coderabbitai[bot] authored Dec 14, 2024
commit b37ef741e51fb34b604ef4f7ee4ef2e3020aa12f
2 changes: 1 addition & 1 deletion internal/clouds/general/location.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
return region, zone, nil
}
l.Warnf("Unknown cloud provider: %s", cloudProvider)
return location, location, nil
return "", "", fmt.Errorf("unknown cloud provider: %s", cloudProvider)

Check failure on line 60 in internal/clouds/general/location.go

View workflow job for this annotation

GitHub Actions / test

undefined: fmt
}

// ParseRegionZone takes either a region (e.g., us-east-1) or zone (e.g., us-east-1a)
Expand Down
Loading