[Test Case]: Track Structures Turnout Panel #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czapplitec
changed the title
…ps://github.com/IFCRail/MVD-Infra-Test-Instructions into Test_Instruction_Track_Structures_Turnout_Panel
pjanck
requested changes
Mar 1, 2022
E2a-TRST/TSTP/Dataset/README.md
Outdated
| A track turnout panel is modelled as an instance of IfcElementAssembly with Predefined Type TURNOUTPANEL. | ||
| It is decomposed by elements including IfcRail.RAIL, IfcTrackElement.SLEEPER, IfcRail.CHECKRAIL, IfcTrackElement.FROG, IfcMechnicalFastner.RAILFASTNING, IfcMechnicalFastner.RAILJOINT. | ||
| All the placement of these elements should be based on the placement of the turnout panel, and the turnout panel as an assembly is placed based on the alignment. | ||
| It is required to define the explicit and start and end stationing of the turnout panel. |
There was a problem hiding this comment.
- typo: explicit and start?
- perhaps a mention that these should be
IfcReferents would be beneficial
There was a problem hiding this comment.
Updated, thanks
E2a-TRST/TSTP/README.md
Outdated
|
|
||
| - IfcElementAssembly | ||
| - *There exists 1 IfcElementAssembly with PredefinedType set to TRACKTURNOUTPANEL* | ||
| - *Each IfcElementAssembly/TRACKTURNOUTPANEL shall have a linear placement relative to the alignment* |
There was a problem hiding this comment.
The sketch Turnout_Placement.png disagrees with this statement.
There was a problem hiding this comment.
This contraint is removed
E2a-TRST/TSTP/README.md
Outdated
| - *There exists 1 IfcElementAssembly with PredefinedType set to TRACKTURNOUTPANEL* | ||
| - *Each IfcElementAssembly/TRACKTURNOUTPANEL shall have a linear placement relative to the alignment* | ||
| - *Each IfcElementAssembly/TRACKTURNOUTPANEL is spatially contained in an IfcRailwayPart/TRACKSUPERSTRUCTURE* | ||
| - *Each IfcElementAssembly/TRACKTURNOUTPANEL shall have a product span placement* |
There was a problem hiding this comment.
What is product span placement? Can you point me to the documentation?
There was a problem hiding this comment.
There was a problem hiding this comment.
I may have missed somewhere in the readme: Regarding E2a-TRST/TSTP/Dataset/Sleeper: is it expected to have the 3D model according to the real situation or the simplified situation?
Stated in Dataset/README.md line 30:
- The geometry of IfcTrackElement.SLEEPER can be simplified and placed according to the drawing in Fig. 6.
pjanck
reviewed
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Outline of the content and tasks addressed by this pull request, don't forget to link the relevant issue(s)
Purpose
Please mark the relevant tasks that this pull request creates or updates: #28
Exchanges
Test Cases
General