[Test Case]: Alignment Railway Cant 1 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czapplitec
requested review from
AlexBrad1eyCT,
apinzenoehler and
SergejMuhic
pjanck
requested changes
Mar 1, 2022
E1b-ARCT/ALCT1/Dataset/README.md
Outdated
Comment on lines
51
to
53
| #### Horizontal Segments | ||
| | start_point_x | start_point_y | start_direction | start_radius_of_curvature | end_radius_of_curvature | segment_length | gravity_center_line_height | predefined_type | | ||
| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | |
There was a problem hiding this comment.
I'd prefer to also see the units of each column somewhere. Applies to all three tables.
There was a problem hiding this comment.
Units are added
E1b-ARCT/ALCT1/README.md
Outdated
| - Minimum set of spatial structure | ||
| - One alignment for railway including horizontal, vertical and cant layouts | ||
| - Alignment segments including linear segments, circular arc segments and clothoid transition segments | ||
| - Alignment design covers the scenaio that vertical alignment is measured from track center line so left and right cant are reciprocal at each point along alignment |
There was a problem hiding this comment.
Suggested change
| - Alignment design covers the scenaio that vertical alignment is measured from track center line so left and right cant are reciprocal at each point along alignment | |
| - Alignment design covers the scenario that vertical alignment is measured from track center line so left and right cant are reciprocal at each point along alignment |
E1b-ARCT/ALCT1/README.md
Outdated
Comment on lines
139
to
149
| > 1. The deviation between the end point of an IfcAlignmentHorizontalSegment and the start point of subsequent IfcAlignmentHorizontalSegment must be smaller than 0.0001m. | ||
| > 1. The deviation between the end point of an IfcAlignmentVerticalSegment and the start point of subsequent IfcAlignmentVerticalSegment must be smaller than 0.0001m. | ||
| > 1. The deviation between the end point of an IfcAlignmentCantSegment and the start point of subsequent IfcAlignmentCantSegment must be smaller than 0.0001m. | ||
| > 1. In case of transition code "CONTSAMEGRADIENT", the deviation between the end direction of an IfcAlignmentHorizontalSegment and the start direction of subsequent IfcAlignmentHorizontalSegment must be smaller than 0.000001 radian. | ||
| > 1. In case of transition code "CONTSAMEGRADIENT", the deviation between the end direction of an IfcAlignmentVerticalSegment and the start direction of subsequent IfcAlignmentVerticalSegment must be smaller than 0.000001 radian. | ||
|
|
||
|
|
||
| > 1. The geometric representation of alignment horizontal (IfcCompositeCurve segments) should be consistent with the semantic counterpart (list of IfcAlignmentHorizontalSegment). | ||
| > 1. The geometric representation of alignment horizontal (IfcGradientCurve segments) should be consistent with the semantic counterpart (list of IfcAlignmentVerticalSegment). | ||
| > 1. The geometric representation of alignment horizontal (IfcSegmentedReferenceCurve segments) should be consistent with the semantic counterpart (list of IfcAlignmentCantSegment). | ||
| - *Constraint* |
There was a problem hiding this comment.
If we are checking IFC files only, how can this be checked?
E1b-ARCT/ALCT1/README.md
Outdated
|
|
||
| - All the concept templates must be correctly implemented as presented in the validation criteria | ||
| - At least 1 instance of each entity listed in [Itemised Roots](#Itemised-Roots) is present in the file. | ||
| - 1 IfcAlignment instance is expected to be present in the file. The alignment layouts |
There was a problem hiding this comment.
It seems that the sentence is incomplete.
E1b-ARCT/ALCT1/README.md
Outdated
Comment on lines
192
to
193
| | GENE_02 | The model contains exactly 1 IfcAlignment | per [Entities Table](Dataset/README.md#Entities-Table) | | | ||
| | GENE_02 | The IfcAlignment nests exactly 1 IfcAlignmentHorizontal, exactly 1 IfcAlignmentVertical and exactly 1 IfcAlignmentCant | per [Entities Table](Dataset/README.md#Entities-Table) | | |
E1b-ARCT/ALCT1/README.md
Outdated
Comment on lines
204
to
213
| ### Some Concept Group | ||
|
|
||
| <details><summary>Click to expand</summary> | ||
| Criteria around the representation of 'Some Concept' | ||
|
|
||
| | **ID** | **CRITERIA** | **VALUE** | **COMMENT** | | ||
| |---------|-----------------------------------------------------|------------------------------------------|-------------| | ||
| | XXXX_01 | A Criteria to follow | its expected value or outcome | | | ||
|
|
||
| </details> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Outline of the content and tasks addressed by this pull request, don't forget to link the relevant issue(s)
Purpose
Please mark the relevant tasks that this pull request creates or updates: #11
Exchanges
Test Cases
General