Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS_GMN16_IfcTunnel_Sprint_1_1 #39

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gmn3DS
Copy link
Contributor

@gmn3DS gmn3DS commented Feb 8, 2023

Test File For IfcTunnel_Sprint_1_1

Provide a short summary (3-5 lines):
For example, is it a new file, an update to an existing one?
Provide some bullet points about the content of the file, e.g. terrain model, tunnel structure, etc.

Covered Concept Templates - Usages Included

Please list all Usages you have implemented.

Miscellaneous

First Time Using GitHub also, getting my hand at it

@gmn3DS gmn3DS changed the title Sprint01 3DS_GMN16_IfcTunnel_Sprint_1_1 Feb 8, 2023
Copy link
Collaborator

@larswik larswik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing suggestion and adding an IfcRelDeclares should fix it.

#34=IFCDIRECTION((1.,0.,0.)) ;
#11=IFCAXIS2PLACEMENT3D(#12,#13,#14) ;
#31=IFCAXIS2PLACEMENT3D(#32,#33,#34) ;
#15=IFCGEOMETRICREPRESENTATIONCONTEXT($,'Model',3,1.E-05,#11,$) ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#15=IFCGEOMETRICREPRESENTATIONCONTEXT($,'Model',3,1.E-05,#11,$) ;
#15=IFCGEOMETRICREPRESENTATIONCONTEXT('3D','Model',3,1.E-05,#11,$) ;

Comment on lines +7 to +11
<<<<<<< HEAD
=======
paths:
- "**.ifc"
>>>>>>> refs/remotes/origin/Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have merge conflicts' git's syntax committed here. Please revert such additions / delete such added lines. If you need help, we can have a quick call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me when you are free to have a call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #67 - has this PR been superseded and can thus be closed? Perhaps we don't even need to resolve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants