Hides corresponding labels when author or tags are empty #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the menus from config
kshcherban
reviewed
Mar 14, 2018
| <a href="{{ .Site.BaseURL }}{{ .Site.LanguagePrefix }}/tags/">{{ i18n "tags" }}</a> | ||
| <a href="{{ .Site.BaseURL }}{{ .Site.LanguagePrefix }}/contact/">{{ i18n "contact" }}</a> |
There was a problem hiding this comment.
I guess, About and Contacts may be set through the main menu.
azmelanar
requested changes
Mar 18, 2018
| <a href="{{ .Site.BaseURL }}{{ .Site.LanguagePrefix }}/about/">{{ i18n "about" }}</a> | ||
| {{ $currentPage := . }} | ||
| {{ range .Site.Menus.main }} | ||
| <a class="nav-item{{if or ($currentPage.IsMenuCurrent "main" .) ($currentPage.HasMenuCurrent "main" .) }} active{{end}}" href="{{.URL}}">{{ .Name }}</a> |
There was a problem hiding this comment.
please add i18n support for naming of menu items
| @@ -36,6 +36,11 @@ theme = "pixyll" | |||
| twitter_username = "username" | |||
| disqus_shortname = "sitename" | |||
| paginate = true | |||
|
|
|||
| [[menu.main]] | |||
There was a problem hiding this comment.
please add this menu to exampleSite configuration as well to show the support for menu items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes use of the menus from config