bugfix: LOG2RAM_LOG, extended by sync_to_disk, is rescued to hdd.path #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeated start) (without stop) does not cause additional "mount --bind" anymore
LOG2RAM_LOG, extended by sync_to_disk, needs to be rescued separately
cleanup at stop)
LOG2RAM_LOG, extended by sync_to_disk, is rescued to hdd.path
HoTschir
changed the title
|
Since log2ram_log is for rsync/cp copy logs, I wasn't expecting copy the file into disk. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While sync_to_disk is executed rsync or cp copies content of path to hdd.path. Logging of this is done at $LOG2RAM_LOG, which is located at $RAM_LOG. In case of executing sync_to_disk inside stop) command, subsequently $RAM_LOG will be unmounted. Changes are lost. The fix separately copies $LOG2RAM_LOG to $HDD_LOG to keep the sync_to_disk content.