chore: enables multiple new tsconfig safety flags
#431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand the benefit of the Also your PR commit type should be renamed from "feat" to "chore" or "refactor". Because "feat", "fix" and "perf" are automatically included in changelog, which is not the information users need. |
hugop95
changed the title
tsconfig safety flagstsconfig safety flags
- `allowUnreachableCode`, `noUnusedLocals`, `noUnusedParameters` and `noImplicitReturns`.
hugop95
force-pushed
the
feat/noUncheckedIndexedAccess
branch
from
0cbab22 to
a4f3a6d
Compare
Oops, forgot about it, renamed.
https://www.typescriptlang.org/tsconfig/#noPropertyAccessFromIndexSignature
|
azat-io
approved these changes
Dec 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typescript documentation: https://www.typescriptlang.org/tsconfig.
This PR enables the following flags in
tsconfig.jsonto strengthen type-safety in the project.noUnusedLocals: true(no code impacted)noUnusedParameters: true(no code impacted)noImplicitReturns: true(no code impacted)allowUnreachableCode: false(no code impacted)noUncheckedIndexedAccess: true(code impacted here: 454fe7b)noPropertyAccessFromIndexSignature: true(code impacted here: ff9563d)Additional interesting flags not added in this PR:
exactOptionalPropertyTypesWhat is the purpose of this pull request?