WIP: Reduce Explosion of Aya Error Types #1061
Draft
+3,230
−3,848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for aya-rs-docs failed.
|
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
I have been down a rabbit hole of cleaning up the aya error types 😅 Most of the important changes are in `errors.rs`. TL;DR Current exposed types are: - `EbpfError` - `ProgramError` - `MapError` - `LinkError` - `PerfBufferError` - `SysError` Honestly I'm still thinking about how we could collapse those types. Either into a single type, or at least fewer than we expose today. Within each of those types, I've tried to remove any invariants that don't have any business being public (e.g if a syscall fails with -EINVAL, there is nothing at runtime you can do about it other than bailing). 👆 (and the spaghetti of errors depending on other errors) are replaced by an `Other` invariant that's a Box<dyn std::error::Error>. There are still some `pub(crate) XInternalError` types, but these are used only to make nice error messages. This could plausibly be replaced with anyhow/context etc.. But I've left it as-is for now. Signed-off-by: Dave Tucker <[email protected]>
dave-tucker
force-pushed
the
errors-api
branch
from
cb72b70
to
e899c8e
Compare
|
I was wondering if the errors from |
Good call! I missed those on the first pass through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been down a rabbit hole of cleaning up the aya error types 😅
Most of the important changes are in
errors.rs.TL;DR
Current exposed types are:
EbpfErrorProgramErrorMapErrorLinkErrorPerfBufferErrorSysErrorHonestly I'm still thinking about how we could collapse those types.
Either into a single type, or at least fewer than we expose today.
Within each of those types, I've tried to remove any invariants
that don't have any business being public (e.g if a syscall fails
with -EINVAL, there is nothing at runtime you can do about it
other than bailing).
👆 (and the spaghetti of errors depending on other errors) are
replaced by an
Otherinvariant that's aBox<dyn std::error::Error>.There are still some
pub(crate) XInternalErrortypes, but theseare used only to make nice error messages. This could plausibly be
replaced with anyhow/context etc.. But I've left it as-is for now.