-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target Framework Updates #389
Conversation
* Reference Cysharp `ZString` v2.6.0 in `SmartFormat` project (net461 target use the netstandard2.0 assemblies) * Remove project `SmartFormat.Zstring` * Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString * Rename ZStringBuilderExtensions to ZStringBuilderUtilities
* Flag `ZStringBuilder` and `ZStringWriter`with `[ExcludeFromCodeCoverage]` * Add AltCoverAttributeFilter="ExcludeFromCodeCoverage" in CI tests
* Directory.Build.props: Remove duplicate entries from Demo and Performance projects * Enable NRT for Demo and Performance projects * Remove folder SmartFormat.ZString from former projects SmartFormat.ZString * Remove obsolete entries from SmartFormat.sln * Remove reference to former SmartFormat.ZString.dll from SmartFormat.csproj
Fix nullability issues caused by net60 target framework
* Mark CTOR overload (System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) as obsolete (like it is in net8.0). * Update proprocessor directives and nuget packages * Change appveyor_build_worker_image to Ubuntu2204 * Add net8.0 as target framework * Update target framework net461 to net462
Quality Gate passedIssues Measures |
@karljj1 Somehow you got lost as a project maintainer. I have sent you a new invitation and hope you'll accept. Could you review this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Looks good. I didnt check all 300+ files though ;)
Almost all of the 380 changed files are deletions coming form |
.NET Framework 4.6.2
SmartFormat has transitioned to using
.NET Framework 4.6.2 (net462)
as its target framework, replacing the now unsupported.NET Framework 4.6.1 (net461)
. The support fornet461
ended in 2022, whilenet462
will continue to receive support until January 2027.Switching to a different patch version of a target framework is generally not considered a breaking change. This is referred to as an in-place update by Microsoft. In the case of SmartFormat, we have not encountered any runtime issues with the existing API after this transition.
The same holds true for the new
netstandard2.0
reference to ZString..NET 6.0 and .NET 8.0
SmartFormat has expanded its compatibility by adding
.NET 6.0 (net60)
and.NET 8.0 (net80)
as additional target frameworks. You can find details about their end of support here.All Target Frameworks
We have removed the
SmartFormat.ZString
assembly and replaced it with a reference to the ZString package. This change does not affect the API.