Fix: ObjectPool uses PoolSettings.IsPoolingEnabled (#400)

src/SmartFormat.Tests/Core/FormatterTests.cs

@@ -344,4 +344,4 @@ public void Parallel_Smart_Format()
         // Restore to saved value
         ThreadSafeMode.SwitchTo(savedMode);
     }
-}
+}

src/SmartFormat.Tests/Pooling/ObjectPoolClassesTests.cs

@@ -229,7 +229,7 @@ public void Should_Not_Exceed_Maximum_Pool_Size(object poolAsObj)
     public void Dispose_Should_Clear_The_Pool(object poolAsObj)
     {
         const int shouldBeCreated = 5;
-
+        
         var pool = (ObjectPool<SomePoolObject>) poolAsObj;
 
         for (var i = 1; i <= shouldBeCreated; i++)
@@ -255,6 +255,7 @@ public void Dispose_Should_Clear_The_Pool(object poolAsObj)
     public void Disabled_Pooling_Should_Only_Return_New_Instances(object poolAsObj)
     {
         var pool = (ObjectPool<SomePoolObject>) poolAsObj;
+        var savedPoolingEnabled = pool.IsPoolingEnabled;
         pool.IsPoolingEnabled = false;
 
         var active = new List<SomePoolObject>();
@@ -267,6 +268,7 @@ public void Disabled_Pooling_Should_Only_Return_New_Instances(object poolAsObj)
         {
             pool.Return(a);
         }
+        pool.IsPoolingEnabled = savedPoolingEnabled;
 
         Assert.Multiple(() =>
         {

src/SmartFormat.Tests/Pooling/PoolBalanceTests.cs

@@ -112,7 +112,7 @@ public void Pooling_Disabled_Leaves_Pools_Empty()
 
         foreach (var p in pools)
         {
-            Assert.That(p.Counters!.CountAll, Is.EqualTo(0), "CountAll");
+            Assert.That(p.Counters!.CountAll, Is.EqualTo(0), $"{p.Type?.Name}: CountAll");
         }
     }
-}
+}

src/SmartFormat/Core/Formatting/FormattingInfo.cs

@@ -84,7 +84,7 @@ public FormattingInfo Initialize (FormattingInfo? parent, FormatDetails formatDe
     public void ReturnToPool()
     {
         Parent = null;
-        // Assign new value, but leave existing references untouched
+        // Assign new value, instance is returned to the pool elsewhere
         FormatDetails = InitializationObject.FormatDetails;
         Placeholder = null;
         Selector = null;

src/SmartFormat/Pooling/ObjectPools/ObjectPool.cs

@@ -31,7 +31,11 @@ protected ObjectPool(PoolPolicy<T> poolPolicy)
     /// Indicates whether object pooling is enabled (<see langword="true"/>).
     /// <para>Default is taken from <see cref="PoolSettings.IsPoolingEnabled"/></para>
     /// </summary>
-    public bool IsPoolingEnabled { get; internal set; } = PoolSettings.IsPoolingEnabled;
+    public bool IsPoolingEnabled
+    {
+        get => PoolSettings.IsPoolingEnabled;
+        internal set => PoolSettings.IsPoolingEnabled = value;
+    }
 
     /// <summary>
     /// The configuration of how an <see cref="IObjectPool{U}"/> works.
@@ -118,4 +122,4 @@ public void Dispose()
     }
 
     #endregion
-}
+}