Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/fetcher: don't skip block/header when parent is not found #633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

eth/fetcher: don't skip block/header when parent is not found #633

wants to merge 1 commit into from

Commits on Nov 21, 2024

  1. eth/fetcher: don't skip block/header when parent is not found 

    Currently, we simply skip importing block/header when parent block/header is not
found. However, since multiple blocks can be imported in parallel, the not
found parent might be due to the fact that the parent import does not finish
yet. This leads to a suitation that the correct block in canonical chain is
skipped and the node gets stuck until the peer timeout. We observe this behavior
when there are reorgs and block import is time consuming.

This commit fixes it by creating a new queue for those missing parent blocks and
re-import them after the parent is imported.
    @minh-bq
    minh-bq committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7ee0cf9 View commit details
    Browse the repository at this point in the history