-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chainconfig: add Shillin and Antenna hardfork on mainnet #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
commented
Oct 4, 2023
Comment on lines
+32
to
+33
"shillinBlock": 28825400, | ||
"antennaBlock": 28825400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://app.roninchain.com/block/28825400 -> estimated hardfork time 14:00 UTC+7 Oct 26
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
minh-bq
force-pushed
the
config/hardfork-mainnet
branch
from
October 4, 2023 07:02
e45915b
to
58e60a3
Compare
DNK90
approved these changes
Oct 4, 2023
nxqbao
reviewed
Oct 4, 2023
Comment on lines
+26
to
+27
"profileContract": "0x840EBf1CA767CB690029E91856A357a43B85d035", | ||
"finalityTracking": "0xA30B2932CD8b8A89E34551Cdfa13810af38dA576" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked. Seems ok.
nxqbao
approved these changes
Oct 4, 2023
minh-bq
added a commit
that referenced
this pull request
Oct 4, 2023
* chainconfig: add Shillin and Antenna hardfork on mainnet * p2p: move ping handling into pingLoop goroutine (#27887) Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup. * params/version: bump Ronin to version 2.6.2 --------- Co-authored-by: Felix Lange <[email protected]>
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…y#365) * chainconfig: add Shillin and Antenna hardfork on mainnet * p2p: move ping handling into pingLoop goroutine (#27887) Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup. * params/version: bump Ronin to version 2.6.2 --------- Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated hardfork time 14:00 UTC+7 Oct 26 (https://app.roninchain.com/block/28825400)