monitor/finality: add flag to enable finality vote monitor #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds monitor.finalityvote flag to enable finality vote monitor.
In common case, non-validator nodes doesn't need to enable fast finality sign so we make this environment variable default to be false.
minh-bq
force-pushed
the
feat/monitor-finality-flag
branch
from
514b1d6
to
6b7f121
Compare
DNK90
approved these changes
Oct 2, 2023
minh-bq
added a commit
that referenced
this pull request
Oct 4, 2023
* monitor/finality: add flag to enable finality vote monitor This commit adds monitor.finalityvote flag to enable finality vote monitor. * Dockerfile: set ENABLE_FAST_FINALITY_SIGN default to be false In common case, non-validator nodes doesn't need to enable fast finality sign so we make this environment variable default to be false.
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…ity#358) * monitor/finality: add flag to enable finality vote monitor This commit adds monitor.finalityvote flag to enable finality vote monitor. * Dockerfile: set ENABLE_FAST_FINALITY_SIGN default to be false In common case, non-validator nodes doesn't need to enable fast finality sign so we make this environment variable default to be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds monitor.finalityvote flag to enable finality vote monitor.
In common case, non-validator nodes doesn't need to enable fast finality sign so
we make this environment variable default to be false.