Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proto)!: upgrade proto to cosmos sdk v0.47 #2225

Open
wants to merge 2 commits into
base: cosmos-sdk-v0.47
Choose a base branch
from
Open

feat(proto)!: upgrade proto to cosmos sdk v0.47 #2225

wants to merge 2 commits into from

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Jan 21, 2025 •
edited
Loading

Description

This PR introduces the following changes to streamline proto file management:

  • Introduce buf for Proto Dependency Management
  • Remove Third-Party Proto Files
  • The proto-swagger-gen tool now fetches third-party proto files on the fly during the build process, eliminating the need to store them locally.
  • Use cosmos proto-builder to build proto files

Most of files are auto generated, reviewers only need to focus on the following changes:

  • scripts/
  • Makefile
  • proto/

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx force-pushed the proto branch 14 times, most recently from 50d12ad to 3b5e209 Compare January 21, 2025 21:56
@haiyizxx haiyizxx added the enhancement New feature or request label Jan 22, 2025
@haiyizxx haiyizxx marked this pull request as ready for review January 22, 2025 15:13
@haiyizxx haiyizxx requested a review from a team as a code owner January 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haiyizxx