feat: add stellar upgrader contract to the deploy-contract.js script #487
Conversation
| await broadcast(operation, wallet, chain, 'Upgraded contract', options); | ||
| chain.contracts[contractName].wasmHash = serializeValue(newWasmHash); | ||
| printInfo('Contract upgraded successfully!', contractAddress); | ||
| } | ||
|
|
||
| async function createUpgradeAuths(contractAddress, newWasmHash, migrationData, chain, wallet) { | ||
| // 20 seems a reasonable number of ledgers to allow for the upgrade to take effect |
There was a problem hiding this comment.
Create a global constant for it. Could also create an option with a default of 20 though I don't see us configuring it
There was a problem hiding this comment.
you mean for the 20? What would be the benefit of that? It's literally just used here once, and, as you point out, that doesn't seem like something we would ever parameterize
There was a problem hiding this comment.
yeah, parameterization seems overkill. Would still be nice to define a constant variable for it though for style
| node stellar/deploy-contract.js upgrade <CONTRACT_NAME> --chain-name <CHAIN_NAME> --wasm-path ../axelar-cgp-soroban/target/wasm32-unknown-unknown/release/<CONTRACT_NAME>.optimized.wasm --new-version <NEW_VERSION> --migration-data <MIGRATION_DATA> | ||
| ``` | ||
|
|
||
| where `<CONTRACT_NAME>` is the name of the contract to be upgraded and `--wasm-path` points to the upgraded bytecode. As a sanity check, `<NEW_VERSION>` must match the version number defined by the provided bytecode, so upgrading to the wrong version can be prevented. `<MIGRATION_DATA>` is the json encoded data that will be passed to the contract's `migrate` function. |
There was a problem hiding this comment.
Can you mention how MIGRATION_DATA is encoded for the no migration case and a more complex migration case?
| await broadcast(operation, wallet, chain, 'Upgraded contract', options); | ||
| chain.contracts[contractName].wasmHash = serializeValue(newWasmHash); | ||
| printInfo('Contract upgraded successfully!', contractAddress); | ||
| } | ||
|
|
||
| async function createUpgradeAuths(contractAddress, newWasmHash, migrationData, chain, wallet) { | ||
| // 20 seems a reasonable number of ledgers to allow for the upgrade to take effect |
There was a problem hiding this comment.
yeah, parameterization seems overkill. Would still be nice to define a constant variable for it though for style
AXE-6746