Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] Man improvements #1290

Merged
merged 3 commits into from
Dec 1, 2024
Merged

[GIT PULL] Man improvements #1290

merged 3 commits into from
Dec 1, 2024

Conversation

wlukowicz
Copy link
Contributor

Several fixes and improvements to the man pages:

  • fixed buf ring registration flags,
  • fixed title headings,
  • improved IORING_REGISTER_BUFFERS2 description.

git request-pull output:

The following changes since commit 9032c80cdc7e64bf146ec801fa8917bed6493075:

  man/io_uring_register_sync_cancel.3: update io_uring_sync_cancel_reg (2024-11-29 09:14:14 -0700)

are available in the Git repository at:

  https://github.com/wlukowicz/liburing man-fixes

for you to fetch changes up to 416d96ce5a4bb0ffb366b93a3c7333842cc290d8:

  man/io_uring_register.2: improve IORING_REGISTER_BUFFERS2 description (2024-12-01 15:44:56 +0000)

----------------------------------------------------------------
Wojciech Łukowicz (3):
      man: fix buf ring registration flags
      man: fix title headings
      man/io_uring_register.2: improve IORING_REGISTER_BUFFERS2 description

 man/io_uring.7                     |  6 +++---
 man/io_uring_prep_msg_ring_fd.3    |  2 +-
 man/io_uring_prep_read_fixed.3     |  2 +-
 man/io_uring_prep_timeout.3        |  2 +-
 man/io_uring_prep_timeout_update.3 |  2 +-
 man/io_uring_prep_write_fixed.3    |  2 +-
 man/io_uring_register.2            | 31 +++++++++++++++++++++++--------
 man/io_uring_register_buf_ring.3   | 10 +++++-----
 man/io_uring_setup_buf_ring.3      | 12 ++++++------
 man/io_uring_sq_space_left.3       |  2 +-
 10 files changed, 43 insertions(+), 28 deletions(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <[email protected]>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <[email protected]>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

IORING_REGISTER_PBUF_RING is the opcode, while IOU_PBUF_RING_INC
is the described flag.

Also added version information and aligned formatting.

Signed-off-by: Wojciech Łukowicz <[email protected]>
Made sure title headings match what the page describes.

Signed-off-by: Wojciech Łukowicz <[email protected]>
The section on IORING_REGISTER_BUFFERS_UPDATE mentions sparse entries,
so described how they can be registered.

Also improved formatting.

Signed-off-by: Wojciech Łukowicz <[email protected]>
@axboe
Copy link
Owner

axboe commented Dec 1, 2024

Looks good, thanks.

@axboe axboe merged commit 231d5c2 into axboe:master Dec 1, 2024
15 checks passed
@wlukowicz wlukowicz deleted the man-fixes branch December 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants