-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiler tf native training #420
base: master
Are you sure you want to change the base?
Profiler tf native training #420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
===========================================
- Coverage 76.91% 62.72% -14.19%
===========================================
Files 113 113
Lines 10195 10237 +42
===========================================
- Hits 7841 6421 -1420
- Misses 2354 3816 +1462
Continue to review full report at Codecov.
|
update with origin
851bc3d
to
00eb6ac
Compare
00eb6ac
to
21c4b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, comments are mostly around reducing code redundancy in your implementation and the tests.
Description of changes:
This commit is to enable profiler in the tf2 native training (design doc: https://quip-amazon.com/v0MwAkTizZl9/Profiler-for-TensorFlow2-native-training). The corresponding integration tests for tf 2.2 and 2.3 passed successfully.
TF2.2 integration test: https://console.aws.amazon.com/codesuite/codebuild/072677473360/projects/smprofiler_tf2_integration_tests/build/smprofiler_tf2_integration_tests%3A2bff3f63-b797-4c5e-9992-0fdf17f13bec?region=us-east-1
TF2.3 integration test:
https://console.aws.amazon.com/codesuite/codebuild/072677473360/projects/smprofiler_tf_2_3_integration_tests/build/smprofiler_tf_2_3_integration_tests%3A801a9a02-30b5-4af6-9835-9b01a6ed6ce4/?region=us-east-1
The changes include:
Style and formatting:
I have run
pre-commit install
to ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.