Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade to QuickJS NG #669

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

WIP: Upgrade to QuickJS NG #669

wants to merge 12 commits into from

Conversation

richarddavison
Copy link
Contributor

@richarddavison richarddavison commented Nov 8, 2024

Description of changes

This PR upgrades LLRT to use QuickJS NG.

QuickJS-NG (Next Generation) is a better maintained community owned fork of the original QuickJS source. This fork has a lot of bug fixes, significant performance improvements and more recent ECMA support

  1. Currently there are a few things that's broken. "performance" intrinsic is enabled by default and not writable. A PR has been merged in upstream making it writable
  2. Custom allocators are causing segfaults
  3. Also child_process rust tests are failing due to TypeId not being stable resulting in corrupted Class/Function Vtables. Very strange since it only behaves so for child_process rust test and not anywhere else.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant