-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial implementation of assert module #668
Conversation
If you can typing that is always appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I think a basic assert module is good to have!
09a4785
to
dd25160
Compare
The following verification is still the same before and after the merge of #673 results, with no problems. // index16.js
import assert from 'assert';
console.log(assert);
assert.ok(true);
assert(true);
Will the following events be corrected this time? // index16.js
const assert = require('assert');
console.log(assert);
assert.ok(true);
assert(true);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
Commit#531dea3 caused overlapping prefixes that could not be removed and caused IO errors in the loader. I think I fixed it, but I am not sure if it was fixed correctly... |
@richarddavison , Following this Specifically, the // index17.js
const a = require('call-bind/callBound');
console.log(a) Specifically, the "Fix default CJS exports” will cause an IO error when loading modules, and even if you fix it, an empty object will be returned. Previous state (Commit#0a7509de):
main branch (Commit#6dcd7784):
Commit#2d0e3381:
NOTE: Since this is not a regression generated by this PR, there is no problem in treating it as a separate issue. |
|
2d0e338
to
2aa3573
Compare
Thank you very much. After rebese, the correction in this PR has been reverted. |
Thank you. LGTM. Please rebase of main and i'll merge! |
This branch is already connected to the latest main branch. :) |
Issue # (if available)
#628
Description of changes
The following Node.js APIs, which are also used in the libraries on which
aws-xray-sdk-core
depends, have been implemented. Note that we do not intend to support all APIs from the beginning.Checklist
tests/unit
and/or in Rust for my feature if neededmake fix
to format JS and apply Clippy auto fixesmake check
types/
directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.