Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always disable perl for aws-lc #577

Merged
merged 5 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awscrt/s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class S3Client(NativeResource):
Default values scale with target throughput and are currently
between 2GiB and 8GiB (may change in future)

network_interface_names: (Optional[Sequence(str)])
network_interface_names: (Optional[Sequence(str)])
**THIS IS AN EXPERIMENTAL AND UNSTABLE API.**
A sequence of network interface names. The client will distribute the
connections across network interfaces. If any interface name is invalid, goes down,
Expand Down
4 changes: 1 addition & 3 deletions crt/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ if(UNIX AND NOT APPLE)
set(DISABLE_GO ON CACHE BOOL "Build without using Go, we don't want the extra dependency")
set(BUILD_LIBSSL OFF CACHE BOOL "Don't need libssl, only need libcrypto")

set(DISABLE_PERL ON CACHE BOOL "Build without using Perl, we don't want the extra dependency")
if(CMAKE_C_COMPILER_ID MATCHES "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS "5.0")
set(DISABLE_PERL OFF CACHE BOOL "Build with Perl to avoid using pre-compiled binary with AVX512")
set(MY_ASSEMBLER_IS_TOO_OLD_FOR_512AVX ON CACHE BOOL "Disable AVX512 on old GCC that not supports it")
else()
set(DISABLE_PERL ON CACHE BOOL "Build without using Perl, we don't want the extra dependency")
endif()

add_subdirectory(aws-lc)
Expand Down
2 changes: 1 addition & 1 deletion crt/aws-c-http
2 changes: 1 addition & 1 deletion crt/aws-lc
Loading