Skip to content

Commit

Permalink
remove expected exception when sending a frame after websocket closes…
Browse files Browse the repository at this point in the history
… part of test_send_frame_exceptions test
  • Loading branch information
sbSteveK committed Aug 15, 2024
1 parent e1436c4 commit 0734431
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions test/test_websocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -484,10 +484,13 @@ def bad_completion_callback(data):
# wait for shutdown...
handler.shutdown_future.result(TIMEOUT)

# Change in this PR in aws-c-io https://github.com/awslabs/aws-c-io/pull/650
# along with this PR in aws-c-http https://github.com/awslabs/aws-c-http/pull/474
# allows a window update during shutdown.
# shouldn't be able to send frame after websocket closes
with self.assertRaises(Exception) as raises:
handler.websocket.send_frame(Opcode.TEXT, "asdf")
self.assertIn("AWS_ERROR_HTTP_WEBSOCKET_CLOSE_FRAME_SENT", str(raises.exception))
# with self.assertRaises(Exception) as raises:
# handler.websocket.send_frame(Opcode.TEXT, "asdf")
# self.assertIn("AWS_ERROR_HTTP_WEBSOCKET_CLOSE_FRAME_SENT", str(raises.exception))

self.assertIsNone(handler.exception)

Expand Down

0 comments on commit 0734431

Please sign in to comment.