Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing step for vpa installation #824

Closed
wants to merge 94 commits into from
Closed

Conversation

lsdeva
Copy link

@lsdeva lsdeva commented Jan 9, 2025

Fix for error MountVolume.SetUp failed for volume "tls-certs" : secret "vpa-tls-certs" not found.

kubernetes/autoscaler#4775

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

geoffcline and others added 30 commits November 5, 2024 23:58
darlaker and others added 23 commits December 10, 2024 00:18
This reverts commit 2329a75.
Replaced the external link approach workaround with a fix that allows the preferred cross-reference syntax. Opening inline code with double backticks instead of single backticks was the true source of the problem.
Replaced outside inline code with single backticks instead of double backticks to solve cross-references being rendered incorrectly elsewhere on the page.
Fix for error MountVolume.SetUp failed for volume "tls-certs" : secret "vpa-tls-certs" not found.

kubernetes/autoscaler#4775
@lsdeva lsdeva requested a review from geoffcline as a code owner January 9, 2025 10:18
@lsdeva
Copy link
Author

lsdeva commented Jan 9, 2025

If directly invoke./hack/vpa-up.sh without vpa-tls-certs, vpa-admission-controller pod will stall in ContainerCreating stage.

image

The issue was discussed and the solution was proposed at kubernetes/autoscaler#4775

@geoffcline
Copy link
Contributor

thanks for opening this PR 🥳

I'm researching further

@geoffcline
Copy link
Contributor

hey @lsdeva sorry this was forced closed -- doing repo maintenance

i've made a note of the requested changes and will recreate, apologies

@voelzmo
Copy link

voelzmo commented Jan 16, 2025

Hey, VPA maintainer here 👋
I don't think adding this step should be necessary, this is actually a bug in the vpa 1.2 branch. The fix is on the way and should be released with vpa 1.2.2 soon: kubernetes/autoscaler#7704

If you want to add this as information for users installing vpa 1.2.1 or 1.2.0, you certainly can – but maybe the advice here would rather be to switch to the newer patch release then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.