Corrected self-managed KMS key instructions #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2329a75.
…creating thru the console.
…mat to long format link:
fix v1.31 changelog link typo
Replaced the external link approach workaround with a fix that allows the preferred cross-reference syntax. Opening inline code with double backticks instead of single backticks was the true source of the problem.
Replaced outside inline code with single backticks instead of double backticks to solve cross-references being rendered incorrectly elsewhere on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix to
create-storage-class.htmlto correct instructions for creating self-managed KMS key.The example IAM policy provided on this page is a resource policy that is designed to be used as a key policy attached directly to a KMS key, and is used to grant permissions to specific principals allowed to use the key.
However the instructions were incorrectly suggesting that this policy should be attached to the EKS cluster role. This is not allowed, as the policy contains "Principal" attributes. The instructions also contained an ambiguous statement "Insert the ARN of the new self-managed KMS key." without saying where this ARN should be inserted!
The correct instructions should be to attach the resource policy to the KMS key directly. The page has been updated to reflect this.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.