refactor: convert ConnectorResourceReference from namedtuple to datac…#3830
Open
akshatsinha0 wants to merge 2 commits intoaws:developfrom
Open
refactor: convert ConnectorResourceReference from namedtuple to datac…#3830akshatsinha0 wants to merge 2 commits intoaws:developfrom
akshatsinha0 wants to merge 2 commits intoaws:developfrom
Conversation
reedham-aws
reviewed
Oct 16, 2025
| class ConnectorResourceReference: | ||
| """Reference to a connector resource with all its identifying properties.""" | ||
|
|
||
| logical_id: str |
Contributor
There was a problem hiding this comment.
When looking at all places that reference this class, it seems like there's an instance where logical_id would be None:
serverless-application-model/samtranslator/model/connector/connector.py
Lines 129 to 138 in e7f8b96
Should this be Optional[str]?
Author
There was a problem hiding this comment.
ya ya, because id is not provided in the resource reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
N/A - Addresses TODO comment in project codebase
Description of changes
Refactored
ConnectorResourceReferencefromnamedtupleto@dataclass(frozen=True)(Python 3.8+)Description of how you validated changes
Ran connector test suite:267 test cases
Verified no breaking changes to the public API+immutability
Checklist
Examples?
N/A - Internal refactor with no user-facing changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.