fix(lambda): correcting changeset detection#3737
Open
Vandita2020 wants to merge 8 commits intoaws:developfrom
Open
fix(lambda): correcting changeset detection#3737Vandita2020 wants to merge 8 commits intoaws:developfrom
Vandita2020 wants to merge 8 commits intoaws:developfrom
Conversation
ae9ffa3 to
7fe099f
Compare
Contributor
|
Do you mind providing PR links to any related changes or bug issues for context? |
Contributor
|
It's interesting that this is a bug, but it's not related to an issue we discussed offline. So I don't know exactly what this will do (because this only affects SAM's integration tests, and nothing else). |
Contributor
@valerena do you a link/sim to the issue we discussed offline? |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
With the updates to the parameter values, the changes were not reflected when the changeSet got created, the issue was with the condition used to check if the update is being made.
Previously, the code used
type == "Update"to validate if the action was an update, but it should have beenchangeset_type == "Update".Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.