-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve infinite loop in _find_config on Windows systems #4970
base: master
Are you sure you want to change the base?
Conversation
Quick update: I was unsure about two checklist items and checked them with N/A, because I think they are not applicable for my changes:
Please let me know if there is anything I need to do, to get this merged. Thanks! |
I have been struggling with this for days. Thank you! |
Thanks, hopefully they merge this soon, because this bug is really confusing and frustrating. Especially for new users! |
Hey @nargokul Just following up on this PR! The fix resolves a frustrating infinite loop issue on Windows (#4967) caused by a root path detection method that only worked on Linux. It updates the logic to properly handle cross plattform paths. Looks like the CI is stuck on the wait-for-approval step—would you mind approving it so the checks can run? Let me know if there’s anything else I should adjust. Thanks! |
* Replace Path.match("/") with Path.anchor comparison * Fix infinite loop in _studio.py path traversal
Since this PR seems to be stale, I’d like to follow up to see if there’s anything else needed from my side to move it forward. @benieric, @pintaoz-aws – Would you be able to take a look at this? I’ve recently rebased the branch to the latest master to ensure it’s up-to-date and ready for review. This fix addresses a frustrating bug (#4967) that causes an infinite loop on Windows systems. Resolving this would greatly improve the developer experience, especially for new users facing this issue. Please let me know if any further changes or additional information are needed. Thanks for your time and support! |
Hey sorry for the delay! Thanks for raising this fix and adding tests will look to get this merged ASAP |
Aiming to get this included in next release if tests are passing, thanks! |
Can you run |
Hey @benieric, No worries about the delay—I really appreciate your help! I’ve fixed the formatting style as requested. |
Issue #4967
Description of changes:
This PR fixes an infinite loop in _find_config that occurs on Windows systems. The issue was caused by using Path.match("/") to detect root directories, which never matches on Windows due to different path separators.
Changes made:
Testing done:
Merge Checklist
General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.