-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove sagemaker-local network before compose #4699
base: master
Are you sure you want to change the base?
Conversation
This also fixes the scenario when a user ctrl+c's or |
@mufaddal-rohawala have you had a chance to take a look at this yet? |
@bzheng06 can you force push a temp commit to restart the workflow? |
@sage-maker pushed to restart |
@sage-maker temp commit has been pushed, PR still needs approval |
Can you check integ tests? |
3949352
to
639c826
Compare
639c826
to
f414285
Compare
@sage-maker Synced with the most recent changes to master and pushed |
Issue #, if available:
Issue #4659
Description of changes:
Simple bug fix to the linked issue, run "docker network rm sagemaker-local" before doing the docker compose during setup for a processing job in local mode, stream the output and continue if the network rm fails. The bug I was seeing was from the sagemaker-local network already existing before the job was ran, so this should tear it down before docker-compose and fix it.
Testing done:
No new tests added, ran with existing unit tests locally and results remain the same.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.