Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sagemaker-local network before compose #4699

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bzheng06
Copy link

@bzheng06 bzheng06 commented May 22, 2024

Issue #, if available:
Issue #4659

Description of changes:

Simple bug fix to the linked issue, run "docker network rm sagemaker-local" before doing the docker compose during setup for a processing job in local mode, stream the output and continue if the network rm fails. The bug I was seeing was from the sagemaker-local network already existing before the job was ran, so this should tear it down before docker-compose and fix it.

Testing done:

No new tests added, ran with existing unit tests locally and results remain the same.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bzheng06 bzheng06 requested a review from a team as a code owner May 22, 2024 15:08
@bzheng06 bzheng06 requested review from zhaoqizqwang and removed request for a team May 22, 2024 15:08
@jmahlik
Copy link
Contributor

jmahlik commented May 23, 2024

This also fixes the scenario when a user ctrl+c's or kill -9's the python process running a local mode job so it never cleans up the compose stack. That happens more frequently than one would think.

@bzheng06
Copy link
Author

@mufaddal-rohawala have you had a chance to take a look at this yet?

@sage-maker
Copy link
Collaborator

@bzheng06 can you force push a temp commit to restart the workflow?

@bzheng06
Copy link
Author

@sage-maker pushed to restart

@bzheng06
Copy link
Author

@sage-maker temp commit has been pushed, PR still needs approval

@sage-maker
Copy link
Collaborator

Can you check integ tests?

@bzheng06
Copy link
Author

Can you check integ tests?

@sage-maker Synced with the most recent changes to master and pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants