refactor(s2n-quic-dc): put map impl behind trait #2361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change puts the path secret map behind a trait. This is needed to keep the type concrete while still including a
event::Subscriber
. My goal was to keep anydyn
s we have as high up in the tree as possible to maximize the information the compiler has. With this, it can remove functions that aren't subscribed to, or at least inline them to be inexpensive.Call-outs:
I've spent some time splitting up the
map.rs
module into various submodules. It was getting quite large and no interfaces were really being enforced so there was quite a bit of refactoring involved.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.