feat(s2n-quic): Lazy-init duplicate filter #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a 1MB allocation per endpoint if we never receive a valid token (as is typical, since users need to explicitly opt-in to this with a limiter impl).
camshaft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
n/a
Description of changes:
This avoids a 1MB allocation per endpoint if we never receive a valid token (as is typical, since users need to explicitly opt-in to this with a limiter impl).
Call-outs:
This moves a creation-time allocation to be late (on receipt of valid token). Since we only do this after successful validation I don't think there are any strong concerns from this, but it does likely mean it's possible to distinguish whether an endpoint transitions from "using the filter" to "not using the filter" by measuring network latencies. This seems largely harmless though.
Testing:
No meaningful testing. Just lazy init though.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.