chore(s2n-quic): update MSRV to 1.74.1 #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
partial #2333, resolves #2292
Description of changes:
This change updates the MRSV to 1.74.1
This allows us to update to Criterion 0.5, which removes an unmaintained dependency on
atty. We still need to migrate off of structopt to fully remove this dependency, see #2324It also lets us resolve #2292 by using
[lints.rust.unexpected_cfgs]instead of allowing all configs. I also am including a refactor ofs2n-quic-platform'sbuild.rsthat was intended to allow us to use thecargo::rustc-check-cfgfeature, but it seems that is not available until Rust 1.80.0 (see #2334), so I've left that part of the refactor commented out.Testing:
Builds locally and in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.