-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s2n-quic): expose mtu provider #2232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-mtuPerConn
branch
3 times, most recently
from
June 11, 2024 22:35
4215d1b
to
384a116
Compare
toidiu
changed the title
wip: expose mtu per conn configuration
feat(s2n-quic): expose an mtu provider with connection specific support
Jun 12, 2024
toidiu
changed the title
feat(s2n-quic): expose an mtu provider with connection specific support
feat(s2n-quic): expose an mtu provider
Jun 12, 2024
toidiu
commented
Jun 12, 2024
toidiu
commented
Jun 12, 2024
toidiu
requested review from
camshaft and
WesleyRosenblum
and removed request for
camshaft
June 12, 2024 20:59
toidiu
force-pushed
the
ak-mtuPerConn
branch
3 times, most recently
from
June 14, 2024 02:17
2384ed4
to
f8d9971
Compare
toidiu
changed the title
feat(s2n-quic): expose an mtu provider
feat(s2n-quic): expose mtu provider
Jun 14, 2024
camshaft
reviewed
Jun 18, 2024
camshaft
previously approved these changes
Jun 19, 2024
WesleyRosenblum
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While it is currently possible to specify MTU setting on the IO provider (endpoint specific configuration), an application may want to specify these values per connection.
This PR exposes an MTU provider that allows Applications to provide MTU values at connection granularity. The MTU provider exposes
remote_address
andendpoint_config
, which Applications can use to identify the connection.Usecases:
By default s2n-quic will attempt to set the DF (dont fragment) and do MTU probing on a path. The only way to disable MTU probing is to set the initial, base, and max MTU to the same values. With the inclusion of the MTU provider, Applications can disable MTU probing at the connection level rather than the entire endpoint.
MTU probing can lead to higher path MTUs and therefore lead to better transmission efficiency (25% = (1500-1200)/1200). However, probing for higher MTUs takes time and therefore doesn't benefit Initial and Handshake packets. Applications operating on predictable networks could set the MTU values for known paths and also benefit from efficiency gains during connection establishment.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.