Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: add fields to mtu provider events #2254

Open
toidiu opened this issue Jun 17, 2024 · 0 comments
Open

events: add fields to mtu provider events #2254

toidiu opened this issue Jun 17, 2024 · 0 comments

Comments

@toidiu
Copy link
Contributor

toidiu commented Jun 17, 2024

On error it would be nice to also expose additional fields to help customers debug why the connection level mtu setting failed. Code

  • connection_config: The connection level specific values (propagating the connection config after error makes this tricky to add)
  • remote_addr: the remote address for which the connect mtu values were specified (the lifetime on SocketAddress<'a> makes this tricky to add)
enum DatagramDropReason {
    ...,
    InvalidMtuConfiguration {
        /// MTU configuration for the endpoint
        endpoint_mtu_config: MtuConfig,

        // TODO expose connection level mtu config.
        // connection_config: MtuConfig,
        
         // TODO expose the remote address.
        // remote_addr: SocketAddress<'a>,
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants