feat(runtime): Add session_id support to WebSocket connection methods #186
+77
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add session_id parameter to both generate_ws_connection and generate_presigned_url methods in AgentCoreRuntimeClient to enable proper session tracking in WebSocket connections. Changes: - generate_ws_connection: Add X-Amzn-Bedrock-AgentCore-Runtime-Session-Id header - generate_ws_connection: Update User-Agent to AgentCoreRuntimeClient/1.0 - generate_presigned_url: Add session_id as query parameter via custom_headers - Update unit tests to verify session_id in headers and URL params - Update integration tests to verify session_id end-to-end All tests passing (32 unit tests, 4 integration tests)
Abishek10
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage ? 90.94%
=======================================
Files ? 34
Lines ? 3224
Branches ? 459
=======================================
Hits ? 2932
Misses ? 166
Partials ? 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Minor: Can we also update all the docstring examples where we have listed "AgentRuntimeClient' instead of 'AgentCoreRuntimeClient". - there are 3 docstring updates. |
…imeClient to AgentCoreRuntimeClient
Abishek10
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Contributor
Author
Done |
sundargthb
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add session_id parameter to both generate_ws_connection and generate_presigned_url methods in AgentCoreRuntimeClient to enable proper session tracking in WebSocket connections.
Changes:
All tests passing (32 unit tests, 4 integration tests)
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.