Skip to content

Conversation

rjkerrison
Copy link

Which issue(s) does this change fix?

None.

Why is this change necessary?

"A change got detected" is non-standard English.

How does it address the issue?

It uses "has been" as the past perfect passive auxiliary verb form.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rjkerrison rjkerrison requested a review from a team as a code owner August 14, 2025 13:44
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 14, 2025
@vicheey
Copy link
Contributor

vicheey commented Aug 15, 2025

@rjkerrison , thank you for contributing. Looks like the make pr failed. Do you mind taking a look?

@seshubaws
Copy link
Contributor

@rjkerrison seems there's a linting error

make: *** [lint] Error 1
samcli/lib/providers/sam_function_provider.py:895:121: E501 Line too long (125 > 120)
    |
893 |     def _set_templates_changed(self, paths: List[str]) -> None:
894 |         LOG.info(
895 |             "A change has been detected in the templates %s. Marking templates as changed to be reloaded in the next invoke",
    |                                                                                                                         ^^^^^ E501
896 |             ", ".join(paths),
897 |         )
    |

Found 1 error.

please run make pr to fix, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants