-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[integ-tests] Stablize build image integration tests #6537
Open
hanwen-pcluste
wants to merge
3
commits into
aws:develop
Choose a base branch
from
hanwen-pcluste:developoct29
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore operating systems The docker component we used prior to this commit is not actively maintained and does not support AL2023 Signed-off-by: Hanwen <[email protected]>
…nt failures Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
added
the
skip-changelog-update
Disables the check that enforces changelog updates in PRs
label
Nov 5, 2024
himani2411
reviewed
Nov 6, 2024
@@ -6,7 +6,7 @@ Build: | |||
# Test script custom component with combination (ap-southeast-2, c5.xlarge, centos7) and (ap-southeast-2, c5.xlarge, ubuntu2004) | |||
{% if region == "eu-west-1" %} | |||
- Type: arn | |||
Value: arn:aws:imagebuilder:eu-west-1:aws:component/docker-ce-linux/1.0.0 | |||
Value: arn:aws:imagebuilder:eu-west-1:aws:component/stig-build-linux-high/2024.2.3/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh Is this stig compliant??
himani2411
reviewed
Nov 6, 2024
{% if os in ["ubuntu2204", "rhel9", "rocky9"] %} | ||
# Disable Lustre installation because these newer operating systems release new kernels more often. Lustre usually does not support the latest kernels | ||
DevSettings: | ||
Cookbook: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
himani2411
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits descriptions for details
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.