Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix 'test_create_wrong_pcluster_version' by using 3.10.0 as wrong version. #6323

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gmarciani
Copy link
Contributor

Description of changes

Fix 'test_create_wrong_pcluster_version' by using 3.10.0 as wrong version.

This is required because, starting with Pcluster 3.10.0, the failure for whatever AMI < 3.10.0 would be HeadNodeBootstrapFailure rather than AmiVersionMismatch.

Tests

  • ONGOING test_create_wrong_pcluster_version

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ong version.

This is required because, starting with Pcluster 3.10.0, the failure for whatever AMI < 3.10.0 would be HeadNodeBootstrapFailure rather than AmiVersionMismatch.

Signed-off-by: Giacomo Marciani <[email protected]>
@gmarciani gmarciani added bug skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x bug skip-changelog-update Disables the check that enforces changelog updates in PRs Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant