Windows 7 support #2940
Merged
Windows 7 support #2940
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 690 690
Lines 118745 118746 +1
Branches 16680 16681 +1
=======================================
+ Hits 92884 92892 +8
+ Misses 24972 24963 -9
- Partials 889 891 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
torben-hansen
approved these changes
Jan 14, 2026
samuel40791765
approved these changes
Jan 15, 2026
| !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) | ||
| // ProcessPrng (from `bcryptprimitives.dll`) is only available on Windows 8+. | ||
| #if !defined(__MINGW32__) && defined(_WIN32_WINNT) && _WIN32_WINNT <= _WIN32_WINNT_WIN7 | ||
| #define AWSLC_WINDOWS_7_COMPAT |
Contributor
There was a problem hiding this comment.
Nit: Should we drop the COMPAT? seems like that's already implied like the rest of our compatibility macros like OPENSSL_WINDOWS.
Suggested change
| #define AWSLC_WINDOWS_7_COMPAT | |
| #define AWSLC_WINDOWS_7 |
Merged
justsmth
added a commit
that referenced
this pull request
Jan 22, 2026
### Description of changes: Prepare AWS-LC v1.67.0 #### What's Changed * Migrate Wycheproof test vectors for ECDSA, RSA PKCS#1, and some more by @sgmenda in #2887 * increase timeout for SDE tests by @sgmenda in #2936 * Rename volatile state/memory to unique state/memory by @torben-hansen in #2935 * Fix failing Windows Docker image build by @nhatnghiho in #2931 * Service Indicator: Add error call trampoline to avoid delocator issue by @jakemas in #2920 * Add support for Big Endian in ACVP tool by @samuel40791765 in #2938 * AES-GCM: Add function pointer trampolines to avoid delocator issue by @jakemas in #2919 * Use already defined macro for no inline by @torben-hansen in #2942 * Remove Kyber completely by @torben-hansen in #2941 * Windows 7 support by @justsmth in #2940 * Import mldsa-native by @jakemas in #2902 * Use existing session context if new is actually NULL by @torben-hansen in #2946 * Integrate Wycheproof ML-KEM test vectors by @sgmenda in #2891 * Avoid cross-compilation build failure by @justsmth in #2944 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #1997
Description of changes:
ProcessPrng(frombcryptprimitives.dll) is only available on Windows 8+. So the current code fails at runtime on Windows 7 becauseGetProcAddressreturnsNULLand causes anabort().This change defines
AWSLC_WINDOWS_7_COMPATwhen_WIN32_WINNT <= _WIN32_WINNT_WIN7. Then uses the existingBCryptGenRandomlogic when it's is defined.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.