Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for cipher auth with multiple cert slots #1956

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-2699

Description of changes:

Ruby has a dependency on the multiple certificate slot mechanisms that OpenSSL allows for. We've already done the work to support this, but another Ruby 3.1 test has exposed a gap in our support. We were only depending on the negotiated signature algorithms to retrieve the right certificate for the server to send back, but the cipher authentication scheme was also checked in OpenSSL as well. Ruby's tests happen to only depend on configuring the authentication scheme which brought this to light.
We happen to do this TLS 1.0/1.1 already, this is introducing the same behavior for TLS 1.2.

Call-outs:

WIP

Testing:

WIP

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (318c34c) to head (cf10dc7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
- Coverage   78.71%   78.68%   -0.03%     
==========================================
  Files         587      587              
  Lines      101218   101225       +7     
  Branches    14361    14362       +1     
==========================================
- Hits        79669    79649      -20     
- Misses      20913    20938      +25     
- Partials      636      638       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants