Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Ruby Support - More EVP_PKEY_DSA #1954

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title Ruby Support - More EVP_PKEY_DSA [DRAFT] Ruby Support - More EVP_PKEY_DSA Oct 28, 2024
@justsmth justsmth force-pushed the ruby-EVP_PKEY_DSA branch 7 times, most recently from c17adaa to d339ff5 Compare October 28, 2024 18:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 80.30303% with 65 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8d9809e). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/evp_extra/p_dsa.c 81.31% 37 Missing ⚠️
crypto/evp_extra/evp_extra_test.cc 76.47% 12 Missing and 12 partials ⚠️
crypto/fipsmodule/evp/evp_ctx_test.cc 84.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1954   +/-   ##
=======================================
  Coverage        ?   78.69%           
=======================================
  Files           ?      587           
  Lines           ?   101252           
  Branches        ?    14364           
=======================================
  Hits            ?    79682           
  Misses          ?    20922           
  Partials        ?      648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the ruby-EVP_PKEY_DSA branch 4 times, most recently from 591a7c1 to 8403f71 Compare October 28, 2024 20:46
@justsmth justsmth force-pushed the ruby-EVP_PKEY_DSA branch 2 times, most recently from 7f1b232 to 78ade94 Compare October 29, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants