-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding -verify and expanding -x509 options for our OpenSSL tool #1951
Open
smittals2
wants to merge
12
commits into
aws:main
Choose a base branch
from
smittals2:openssl-tool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage ? 78.79%
=======================================
Files ? 587
Lines ? 101164
Branches ? 14345
=======================================
Hits ? 79716
Misses ? 20813
Partials ? 635 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2679
Description of changes:
-subject
and-fingerprint
options added to the x509 toolverify
tool with-CAfile
verify
tool takes a file as input or defaults to reading from stdinCallouts:
The subject field differs in OpenSSL master and versions <= 3.2. A normalization function that removes whitespaces is used to compare output.
Testing:
Added option tests for new functionality and OpenSSL comparison tests for the new options.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.