Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding -verify and expanding -x509 options for our OpenSSL tool #1951

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Oct 26, 2024

Issues:

CryptoAlg-2679

Description of changes:

  • -subject and -fingerprint options added to the x509 tool
  • A new verify tool with -CAfile
    • The verify tool takes a file as input or defaults to reading from stdin

Callouts:

The subject field differs in OpenSSL master and versions <= 3.2. A normalization function that removes whitespaces is used to compare output.

Testing:

Added option tests for new functionality and OpenSSL comparison tests for the new options.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 54.27350% with 107 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8d9809e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tool-openssl/x509_test.cc 30.64% 43 Missing ⚠️
tool-openssl/verify_test.cc 41.66% 35 Missing ⚠️
tool-openssl/verify.cc 72.82% 25 Missing ⚠️
tool-openssl/x509.cc 80.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1951   +/-   ##
=======================================
  Coverage        ?   78.79%           
=======================================
  Files           ?      587           
  Lines           ?   101164           
  Branches        ?    14345           
=======================================
  Hits            ?    79716           
  Misses          ?    20813           
  Partials        ?      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smittals2 smittals2 marked this pull request as ready for review October 28, 2024 23:38
@smittals2 smittals2 requested a review from a team as a code owner October 28, 2024 23:38
@justsmth justsmth requested review from skmcgrail, andrewhop and justsmth and removed request for skmcgrail October 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants