Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Implement PKCS7_dataInit and PKCS7_dataFinal #1816

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WillChilds-Klein
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 37.12000% with 393 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (04b369f) to head (69cb0fd).

Files with missing lines Patch % Lines
crypto/pkcs7/pkcs7_internal_bio_cipher.c 14.47% 195 Missing ⚠️
crypto/pkcs7/pkcs7_internal_bio_md.c 0.00% 113 Missing ⚠️
crypto/pkcs7/pkcs7.c 66.53% 85 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   78.68%   78.45%   -0.23%     
==========================================
  Files         585      587       +2     
  Lines      100836   101461     +625     
  Branches    14291    14409     +118     
==========================================
+ Hits        79342    79601     +259     
- Misses      20858    21223     +365     
- Partials      636      637       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein force-pushed the pkcs7-bio-data-init-final branch 3 times, most recently from 23e4d39 to 1b0c84d Compare September 5, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants