Bump aws-lc-fips-sys to v0.13.5 #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 95.80% 92.94% -2.86%
==========================================
Files 61 71 +10
Lines 8143 9813 +1670
Branches 0 9813 +9813
==========================================
+ Hits 7801 9121 +1320
- Misses 342 405 +63
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Apr 1, 2025
|
|
||
| function filter_symbols() { | ||
| if [[ "${CRATE_NAME}" =~ fips ]]; then | ||
| grep -E '^\w*$' | grep -v -E "^bignum_" | grep -v "curve25519_x25519" | grep -v "edwards25519_" | grep -v "p256_montj" | grep -v "p384_montj" | grep -v "p521_montj" | grep -v "p521_j" | grep -v "jent_" | grep -v "fips_" | grep -v "fips_check" |
There was a problem hiding this comment.
style nit: you might consider making this pipe-per-line to ease readability and adding/removing clauses
grep -E '$pattern' \
| grep -v -E foo \
| grep -v bar \
...
skmcgrail
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Call-outs:
CI failures
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.