Skip to content

Commit

Permalink
Delete Gemfile.lock (#11)
Browse files Browse the repository at this point in the history
* Delete Gemfile.lock

File was added as part of the fix to the logger but according to [Yehuda Katz](https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/) this was a mistake:

> When developing a gem, use the gemspec method in your Gemfile to avoid duplication. In general, a gem's Gemfile should contain the Rubygems source and a single gemspec line. Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem.

> When developing an app, check in your Gemfile.lock, since you will use the bundler tool across all machines, and the precision enforced by bundler is extremely desirable for applications.

https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

* Add Gemfile.lock to the files ignored by git

For a library this file is better if it is not included ever:

> Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem.

https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
  • Loading branch information
edhzsz authored Jan 21, 2021
1 parent 98f91e3 commit 92007b1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 37 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
vendor
test/examples/hello-world-docker/pkg
*.iml
.DS_Store
.DS_Store
Gemfile.lock
36 changes: 0 additions & 36 deletions Gemfile.lock

This file was deleted.

0 comments on commit 92007b1

Please sign in to comment.