Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditions around CodeArtifact publishing and CodeCov #504

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Aug 6, 2024

Description of changes:

  • protects publishing artifact with a check against ENABLE_SNAPSHOT
  • protects publishing CodeCov with a check against CODECOV_TOKEN

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0e46a2c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage        ?   41.47%           
  Complexity      ?      154           
=======================================
  Files           ?       47           
  Lines           ?     1150           
  Branches        ?      149           
=======================================
  Hits            ?      477           
  Misses          ?      618           
  Partials        ?       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxday maxday changed the title feat: disable CodeArtifact publishing, enable CodeCov publishing feat: add conditions around CodeArtifact publishing and CodeCov Aug 7, 2024
Copy link

@m-rph m-rph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxday maxday merged commit 8af7655 into main Aug 7, 2024
4 checks passed
@maxday maxday deleted the maxday/remove-aws-publishing-action branch August 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants