#142: add Automatic-Module-Name during build #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SingingBush, Would you be able to resolve the conflicts with this PR? Thanks, |
SingingBush
force-pushed
the
feature/JPMS_automatic_module_name
branch
from
83e98d1
to
2ded191
Compare
|
I'm looking into the failing tests and will push another commit |
smirnoal
approved these changes
Sep 4, 2024
update surefire & failsafe plugins update Junit
SingingBush
force-pushed
the
feature/JPMS_automatic_module_name
branch
from
61dfd99
to
c3c1cbb
Compare
|
I've rebased on the latest changes in main. Please re-run workflows. @maxday any chance of getting a second review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #142
Description of changes: Support JPMS by using maven-jar-plugin to add Automatic-Module-Name during build
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.