Objects to represent VPC Lattice V2 request and response. #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great just created #443 for it (forgot to hit submit yesterday). As per https://docs.aws.amazon.com/lambda/latest/dg/services-vpc-lattice.html#vpc-lattice-receiving-events |
|
Added |
deki
suggested changes
Sep 21, 2023
aws-lambda-java-events/pom.xml
Outdated
| @@ -50,6 +50,11 @@ | |||
| <artifactId>joda-time</artifactId> | |||
| <version>2.10.8</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.google.code.findbugs</groupId> | |||
| <artifactId>jsr305</artifactId> | |||
There was a problem hiding this comment.
we shouldn't add that dependency for everyone
There was a problem hiding this comment.
I've changed the dependency to the jetbrains one. There is no standard for this yet, which is a shame. I think it's important to describe the data of the events as best as we can. I hope that @Nullable will be an annotation that is added to more events in the future.
...nts/src/main/java/com/amazonaws/services/lambda/runtime/events/VpcLatticeV2RequestEvent.java
Outdated
Show resolved
Hide resolved
|
would it be possible to have Json samples of this event? it will allow us to test serialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Objects to represent VPC Lattice V2 request and response as documented https://docs.aws.amazon.com/vpc-lattice/latest/ug/lambda-functions.html
Target (OCI, Managed Runtime, both): n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.