-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Benchmark harness improvements & add more service benchmarks #9264
base: benchmarks
Are you sure you want to change the base?
Conversation
scripts/performance/benchmarks.json
Outdated
"name": "s3.sync.upload", | ||
"command": ["s3", "sync", "./test_dir", "s3://bucket/test_dir", "--quiet"], | ||
"name": "dynamodb.getitem", | ||
"command": ["dynamodb", "get-item", "--table-name", "MyTable", "--key", "file://key.json", "--return-consumed-capacity", "TOTAL"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much does the file://
usage impact this output as opposed to specifying the key inline? I see we use it in examples, but curious if it's worth separating DDB's performance from that of file://
? But if it's relatively small compared to the full operation, okay with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One argument for file usage is so that we can have performance testing coverage of that feature of the CLI.
I can see the value of keeping it out if possible. We can also add it as a dimension, "KeyLoadedFromFile": "True".
Issue #, if available:
N/A
Description of changes:
get-item
,batch-get-item
,put-item
commands, and a benchmark for the customizationddb put
.AssumeRole
,GetCallerIdentity
,AssumeRoleWithWebIdentity
.run-benchmarks
script on success is the benchmark results.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.