Skip to content

Conversation

alvazjor
Copy link
Contributor

@alvazjor alvazjor commented Sep 4, 2025

Issue # (if applicable)

Closes #.

Reason for this change

NodeJs22.x version is not yet available in all regions for aws-iso-b partition. Until it is, we need to keep NodeJs18.x as the latest version.

Description of changes

Modified LATEST_NODE_RUNTIME_MAP in fact-table to map aws-iso-b partition to NodeJs18.x version. And updates all required unit and integration tests.

Describe any new or updated permissions being added

NA

Description of how you validated changes

Integ and unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 4, 2025 13:09
@github-actions github-actions bot added the p2 label Sep 4, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 4, 2025
@alvazjor alvazjor added the pr/do-not-merge This PR should not be merged at this time. label Sep 4, 2025
@alvazjor alvazjor force-pushed the alvazjor/iso-b-region-fix branch from a8c9e88 to b1785ff Compare September 4, 2025 13:43
@mrgrain
Copy link
Contributor

mrgrain commented Sep 4, 2025

Could you move it to Node 20?

@alvazjor alvazjor force-pushed the alvazjor/iso-b-region-fix branch from b1785ff to 18dadad Compare September 4, 2025 14:57
@alvazjor alvazjor requested a review from a team as a code owner September 4, 2025 14:57
@alvazjor
Copy link
Contributor Author

alvazjor commented Sep 4, 2025

@mrgrain Node20 is also not available in FFZ region

@alvazjor alvazjor force-pushed the alvazjor/iso-b-region-fix branch from 18dadad to 88ff0e2 Compare September 4, 2025 17:52
@alvazjor alvazjor added p1 and removed p2 pr/do-not-merge This PR should not be merged at this time. labels Sep 4, 2025
Copy link
Contributor

mergify bot commented Sep 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 5, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@alvazjor alvazjor force-pushed the alvazjor/iso-b-region-fix branch 2 times, most recently from 93a0c21 to 0df1e5f Compare September 5, 2025 15:00
@alvazjor alvazjor force-pushed the alvazjor/iso-b-region-fix branch from 0df1e5f to d746997 Compare September 5, 2025 16:37
Copy link
Contributor

mergify bot commented Sep 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f701442 into main Sep 5, 2025
18 of 19 checks passed
@mergify mergify bot deleted the alvazjor/iso-b-region-fix branch September 5, 2025 17:40
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants